Change in libosmocore[master]: log: socket.c: rather use the osmo_sockaddr_str _FMT - gerrit-log

7 Feb 2022


      Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27024 )
Change subject: log: socket.c: rather use the osmo_sockaddr_str _FMT
......................................................................
Patch Set 2:
(1 comment)
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/27024/comment/82f1caca_fe5571ff 
PS1, Line 488: 			osmo_strlcpy(dest->ip, "Invalid IP", 11); \
...
yes, this is criticial to fix before merge.
i think not critical at all, since the use of this macro is limited to this c file, and before this patch the macro also had no such parens. but ok
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idbe7582b2b7f14540919e911dad08af6d491f68f
Gerrit-Change-Number: 27024
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 07 Feb 2022 21:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment