Attention is currently required from: lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/f2cab7e4_8c6... : PS1, Line 8:
You're fixing two messages which were wrong in different ways and had different problems. […]
No. This patch stays exactly like this. Both messages were wrong, and now they agree with the spec. There is nothing else to it, and I'm not interested in wasting more time with bullshit discussions about "how wrong" messages are or splitting a fucking 11 line change into two separate commits.