Attention is currently required from: lynxis lazus.

neels has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email )

Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ......................................................................

Patch Set 9: Code-Review+2

(2 comments)

File tests/msc_vlr/msc_vlr_test_ms_timeout.err:

https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/57b1089e_fc773422?usp=... : PS9, Line 668: GSUP --> HLR: OSMO_GSUP_MSGT_PURGE_MS_REQUEST: 0c010809710000004026f02801020a0101 ^ This change looks different. All the others directly follow an IMSI_DETACH. Here, there is an IMSI DETACH, but it's way up there at line 644...

edit: it's fine. In this test, there is just also a pending Paging and a pending SMS being canceled in-between the IMSI DETACH rx and notifying the HLR.

File tests/msc_vlr/msc_vlr_test_no_authen.err:

https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/f62c6fe2_70381d0b?usp=... : PS9, Line 3020: GSUP --> HLR: OSMO_GSUP_MSGT_PURGE_MS_REQUEST: 0c010809710000004026f02801020a0101 This also looks different from the others; because it shows the case when a subscriber fails to do a periodic LU in time.