Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471 )
Change subject: Reply to BSC's RESET with RESET ACK directly ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc-nat/bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27471/comment/779cde45_3d2688d4 PS1, Line 70: return bssap_ran_rcvmsg_udt(addr, msg, length - sizeof(struct bssmap_header));
shouldn't the length field check in the "if" clause above be checked against sizeof(struct bssmap_he […]
No, because sizeof(struct bssmap_header) is already substracted from length in line 95.
I've based this on how it's done in OsmoBSC: https://git.osmocom.org/osmo-bsc/tree/src/osmo-bsc/osmo_bsc_bssap.c?id=663d6...
-
osmith