Change in osmo-hnodeb[master]: Do not turn some compiler warnings into errors by default
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26884 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Do not turn some compiler warnings into errors by default
We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build.
This patch also effectively removes dependency on autoconf-archive.
Related: OS#5289 Related: SYS#5789 Change-Id: Ie30d8024ee2ad48073dd8be2e02856b6ce1a6b0b --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/84/26884/1
diff --git a/configure.ac b/configure.ac index e96a6a1..9e1e51a 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -115,13 +110,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage,
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26884 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26884 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Do not turn some compiler warnings into errors by default
We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build.
This patch also effectively removes dependency on autoconf-archive.
Related: OS#5289 Related: SYS#5789 Change-Id: Ie30d8024ee2ad48073dd8be2e02856b6ce1a6b0b --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac index e96a6a1..9e1e51a 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -115,13 +110,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage,
-
laforge -
pespin