Change in libosmocore[master]: fsm: fix state_chg(): pass microseconds to osmo_timer_schedule() - gerrit-log

19 Jul 2022

Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28649 )

Change subject: fsm: fix state_chg(): pass microseconds to osmo_timer_schedule()
......................................................................

Patch Set 1:

(1 comment)

File src/fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/28649/comment/e6e6bb8f_1ce47803 
PS1, Line 691: timeout_ms % 1000 
...
  I wouldn't be sure of operator precendence here
without looking at the C standard and would put (tim […] Agree

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28649
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b6c3bdb56e4279df9e5ba7db16841645c452aa
Gerrit-Change-Number: 28649
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 19 Jul 2022 08:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment