fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36143?usp=email ) Change subject: ctrl: Don't expose write_queue in ctrl_cmd_send() api ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Unfortunately, this patch is breaking openbsc: ``` osmo_bsc_ctrl.c: In function 'osmo_bsc_send_trap': osmo_bsc_ctrl.c:55:9: error: implicit declaration of function 'ctrl_cmd_send'; did you mean 'ctrl_cmd_trap'? [-Werror=implicit-function-declaration] 55 | ctrl_cmd_send(&msc_con->write_queue, trap); | ^~~~~~~~~~~~~ | ctrl_cmd_trap ``` https://jenkins.osmocom.org/jenkins/view/master/job/master-openbsc/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic81af56e7ea6921ba39168727ef64c308e9c6754 Gerrit-Change-Number: 36143 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment