fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29588 )
Change subject: coverity: fix prepare_source_Osmocom.sh terminating early ......................................................................
coverity: fix prepare_source_Osmocom.sh terminating early
Since [1] was merged this script is executed with '-xe' making it fail immediately if a command returns a non-zero code. grep may return 1 if pattern is not found, so let's suspend it.
Change-Id: I21a01478b64015fd699ed31634bf2fb1dc8f6750 Fixes: [1] Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved; Verified osmith: Looks good to me, but someone else must approve
diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 63fbea0..526e9d3 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -65,7 +65,7 @@ # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. for proj in $PROJECTS; do - files="$(git -C $proj grep -l check_PROGRAMS)" + files="$(git -C $proj grep -l check_PROGRAMS)" || true if [ -n "$files" ]; then (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) fi