fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27872 ) Change subject: firmware/apps/rssi: remove redundant block in handle_pm() ...................................................................... firmware/apps/rssi: remove redundant block in handle_pm() Below in the common path for both true and false branches we do have a conditional block setting ARFCN_UPLINK if uplink is true. Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 94ecc3b..29c5430 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -916,8 +916,6 @@ a = arfcn; if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) a |= ARFCN_PCS; - if (uplink) - a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; } else { /* mode == MODE_SPECTRUM */ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 Gerrit-Change-Number: 27872 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged