Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/41698?usp=email )
Change subject: add vty setting for ThemWi RTP formats ......................................................................
Patch Set 3:
(1 comment)
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41698/comment/a4e4ced6_9186c62a?usp=... : PS2, Line 711: DEFUN(cfg_msc_twformat1,
I copied the approach that is used in osmo-bsc for per-BTS `codec-support`, `amr tch-f modes` and `a […]
Uh-oh: the cleaner-looking approach recommended by @pespin@sysmocom.de does not work: osmo-msc with that command definition included (3 optional multi-choice arguments) asserts on start-up, in `install_element()` vty code. See Patchset 3 that fails verification tests. Thus I have to go back to my original approach, unless someone can propose a better alternative that works.
-
falconia