Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email ) Change subject: sccp: Split sccp_scoc into multiple files ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: Like many of your patches moving stuff around and splitting it into more files I don't reall see the benefit... it just makes it harder to navigate the code as one always has to use ctags or related to jump between all those files. Just my two cents. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I51e9bf60bc4c4b2babd3f408daed914eaf398e82 Gerrit-Change-Number: 40581 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Jul 2025 14:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes