Attention is currently required from: dexter, laforge, osmith.

Hello Jenkins Builder, laforge, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/41251?usp=email

to look at the new patch set (#3).

The following approvals got outdated and were removed: Verified-1 by Jenkins Builder

Change subject: pySim-shell: allow user friendly selection of the pin type ......................................................................

pySim-shell: allow user friendly selection of the pin type

The CHV commands (verify_chv, enable_chv, disable_chv, unblock_chv) provide a --pin-nr parameter.

The --pin-nr is a decimal parameter that specifies the pin type to be used. The exact pin type numbers are specified in ETSI TS 102.221, Table 9.3.

Unfortunately the --pin-nr parameter is not very intuitive to use, it it requires the user to manually lookup the numeric value. The specs list that value as hexadecimal, so the user also has to convert it to decimal. To make this less complicated, let's also accept hexadecimal numbers with the --pin-nr parameter.

However, this alone does not improve the user expierience much. Let's also add a --pin-type parameter (similar to the --adm-type parameter of the verify_adm command) to specifiy the pin type in a human readable form.

Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c --- M pySim-shell.py 1 file changed, 41 insertions(+), 23 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/51/41251/3