Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email ) Change subject: mgw: Avoid 2nd lookup of conn in endp during CRCX ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39208/comment/62286bf7_57432330?usp… : PS1, Line 1025: conn = mgcp_conn_get_conn_rtp(_conn); It's not really clear from reading what conn and _conn are, renaming conn to rtp{,_}conn would help. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8316e76a1789d4a8eaa1eb89bdaf86e25dc0a1e8 Gerrit-Change-Number: 39208 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No