Attention is currently required from: jolly, fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33448 )
Change subject: ASCI: Add Notification/FACCH support ......................................................................
Patch Set 6:
(5 comments)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/07b0d121_fc069430 PS6, Line 816: * the call is active. Most MSs in dedicated mode may not be able to receive the NCH instead. s/instead/otherwise/
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/5a1624d2_00e3e061 PS6, Line 820: uint8_t chan_desc_len, int count) unsigned count
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/199095e1_45f66374 PS6, Line 826: int tn, ln, n; all these can be unsigned
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/89be0c0a_69679fa7 PS6, Line 837: if (lchan->type != GSM_LCHAN_SDCCH isn't there an lchan_is_dedicated() or alike?
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/8c66d0cb_5e6b495a PS6, Line 845: msgb_tl16v_put(msg, RSL_IE_L3_INFO, sizeof(notif), (uint8_t *) ¬if); can you explain a bit more all this loop with the extra call after it?
-
pespin