Attention is currently required from: osmith.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email )

Change subject: vty: make NCC Permitted (SI2) configurable ......................................................................

Patch Set 1:

(2 comments)

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/15311cbb_105dee79 PS1, Line 1447: no ncc-permitted Using `no ncc-permitted` in order to permit all NCCs looks confusing, IMO. If I were to configure this parameter as a user, I would expect `ncc-permitted all` or something like that. The `no` variant of this command would be useful for disabling specific NCC values, i.e. to disable NCC 2 I would do `no ncc-permitted 2`.

https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/16c75855_15bc7536 PS1, Line 4394: struct gsm_bts *bts const