Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28275 )
Change subject: smscb: Tx CBSP FAILURE/RESTART for specific cell when it becomes (un)operational ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/osmo-bsc/smscb.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28275/comment/3368d5a7_5affd530 PS1, Line 487: cbsp I'm not sure we should tell the CBC that the message data was lost. The BSC keeps all of the SMSCB state, so if a BTS/cell restarts, the BSC will re-install all the SMSCB/ETWS state in the cell [or at least it should, and I think we're doing this].
If we send the "data lost" flag, then the CBC will think it needs to re-send the SMSCB/ETWS for the cell in question, which is not true.