Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )

Change subject: vita demod by piotr krysik, modified ......................................................................

Patch Set 2:

(946 comments)

File Transceiver52M/grgsm_vitac/constants.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/322593ec_5d0b0394 PS2, Line 1: #pragma once DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a308c129_5d92b397 PS2, Line 2: /* -*- c++ -*- */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bbc8cd5_23ec81e2 PS2, Line 3: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/575a4d11_5efb79c2 PS2, Line 4: * @file trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8219c7d_b5f75f17 PS2, Line 5: * @author (C) 2009-2017 by Piotr Krysik ptrkrysik@gmail.com trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed6cf8f1_702d41be PS2, Line 6: * @section LICENSE trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86d77e8d_e34430ea PS2, Line 7: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87d35f0_52a3e43e PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58a14e4d_2fb1fb62 PS2, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8843a62_5be6c06b PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b26ed69_aaca3b79 PS2, Line 11: * any later version. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45108c59_f367bb37 PS2, Line 12: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b2071c1_4ebb6428 PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ab066d9_f4906bca PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5ddcfc2_a2595bca PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def879b2_99e419a4 PS2, Line 16: * GNU General Public License for more details. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e40cce53_52832359 PS2, Line 17: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddfa9e2c_86a8a83b PS2, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78209566_d5c61897 PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/081c94b9_825c722e PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/720dcaa6_acb9f0aa PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99640bc0_5f6a7ce8 PS2, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0486f24_49687faf PS2, Line 22: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1f57d1b_f42a543a PS2, Line 23: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/638129c5_5771f2ee PS2, Line 24: #include <complex> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d7d6e8c_a2e35649 PS2, Line 25: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af5dfd65_e784f012 PS2, Line 26: #define gr_complex std::complex<float> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2080a61_001edee8 PS2, Line 26: #define gr_complex std::complex<float> spaces required around that '<' (ctx:VxV)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f43562eb_fe15cb31 PS2, Line 26: #define gr_complex std::complex<float> spaces required around that '>' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f338741_3324c942 PS2, Line 27: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0f17738_ae4cec7a PS2, Line 28: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def350ee_9f58fb4f PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f77ec7b6_c57ef9f9 PS2, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/997e7902_5e4382d1 PS2, Line 31: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c060efeb_a80d07fa PS2, Line 32: //Burst timing trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/012113f5_7368a011 PS2, Line 33: #define TAIL_BITS 3 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a17334b_03db13bc PS2, Line 34: #define GUARD_BITS 8 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6cc4fcc7_ff6d0089 PS2, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbf75f4c_06f67817 PS2, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b13d0b7a_438da698 PS2, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40c0a781_58af3954 PS2, Line 38: #define STEALING_BIT 1 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1dcd4e95_049efd35 PS2, Line 39: #define N_TRAIN_BITS 26 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9c7ed3a_0cc4305e PS2, Line 40: #define N_SYNC_BITS 64 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3986ffe_6fa59174 PS2, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS ) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bfbfaba_b284e4a0 PS2, Line 42: #define FCCH_BITS USEFUL_BITS DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0242fe0d_64af96dd PS2, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf50e4bc_611d164f PS2, Line 44: #define ACCESS_BURST_SIZE 88 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e67b47ac_47799c75 PS2, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64652455_042f0478 PS2, Line 46: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4aabdd2f_e761d50e PS2, Line 47: #define SCH_DATA_LEN 39 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f58f98b_97de7a24 PS2, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdd1930_c3f17d6b PS2, Line 49: #define TS_PER_FRAME 8 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6757fb6b_7f13a20f PS2, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0684b360_d8ffc025 PS2, Line 51: #define FCCH_POS TAIL_BITS DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d4626d2_43144fa8 PS2, Line 52: #define SYNC_POS (TAIL_BITS + 39) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c2b505d_8123f694 PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2a046dd_d2fcf6c9 PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence space prohibited after that open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f44a9b8c_48595216 PS2, Line 54: //aren't used for channel impulse response estimation trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d21ae8f6_6fdaad3f PS2, Line 55: #define TRAIN_BEGINNING 5 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21048e80_cb3ca857 PS2, Line 56: #define SAFETY_MARGIN 6 // trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e743e96d_67226310 PS2, Line 57: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9ddb925_a4694223 PS2, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84eb07b8_aac18bd0 PS2, Line 59: #define FCCH_MAX_MISSES 1 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed999ca5_bde67488 PS2, Line 60: #define FCCH_MAX_FREQ_OFFSET 100 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f409e1b_0cc38011 PS2, Line 61: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a674add_6a227c65 PS2, Line 62: #define CHAN_IMP_RESP_LENGTH 5 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d8df6e2_91fd05f5 PS2, Line 63: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/065c16b7_432ec99b PS2, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a98bb8db_bd6e8188 PS2, Line 65: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3479e1b_e57fc750 PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ba0f07a_38147b64 PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; do not add new typedefs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fddbfb4_d5677f1e PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ded9505_33bff5cf PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; do not add new typedefs

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7c09303_5e985860 PS2, Line 68: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51e1ca82_3a633586 PS2, Line 69: static const unsigned char SYNC_BITS[] = { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6f3c49_776a543a PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66083918_35310a18 PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f85e5d76_7ffb21bb PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5027d61_172e1b0c PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1207d769_85250e8f PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4843d77_74c593f6 PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/491fcd8c_e760c342 PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83958ae3_eb62a06d PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdedb7c_08f3ab05 PS2, Line 74: }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c50a83c_95019385 PS2, Line 75: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a61c84b_b6955b63 PS2, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d757e3b_5fca85b1 PS2, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eaa5e4e_be9ffe06 PS2, Line 78: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f0792d4_abb06f68 PS2, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98568501_dc605f91 PS2, Line 80: //!!channels so this will be removed from this header trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe9f6ac_61f614b4 PS2, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fde6a217_fce85ffc PS2, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b872eb17_54c73021 PS2, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a61794e_10b370d7 PS2, Line 84: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d28a829b_b181d1b6 PS2, Line 85: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f39b3d0_157e844f PS2, Line 86: #define TSC0 0 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345558f5_e890908c PS2, Line 87: #define TSC1 1 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84533531_73bbf8c9 PS2, Line 88: #define TSC2 2 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9d1e2e3_72f45131 PS2, Line 89: #define TSC3 3 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68a1a8bc_53e46ec5 PS2, Line 90: #define TSC4 4 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bda7e94_3cd2bfe6 PS2, Line 91: #define TSC5 5 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb0910a8_b0a6984b PS2, Line 92: #define TSC6 6 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43cf1280_fdd48d40 PS2, Line 93: #define TSC7 7 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b27f3c1_1f838c50 PS2, Line 94: #define TS_DUMMY 8 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dca0803_ef5e08e4 PS2, Line 95: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c99e8823_f5296ee9 PS2, Line 96: #define TRAIN_SEQ_NUM 9 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4ea35f8_b72c70bc PS2, Line 97: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba21af2_f652a489 PS2, Line 98: #define TIMESLOT0 0 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2730cb0e_467786bf PS2, Line 99: #define TIMESLOT1 1 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c04f94a5_c8c980cc PS2, Line 100: #define TIMESLOT2 2 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1930b07b_f60330b4 PS2, Line 101: #define TIMESLOT3 3 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b9c342a_39146955 PS2, Line 102: #define TIMESLOT4 4 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f488c498_72d203d6 PS2, Line 103: #define TIMESLOT5 5 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cd1b5cb_44817048 PS2, Line 104: #define TIMESLOT6 6 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c05aca46_0678b6bd PS2, Line 105: #define TIMESLOT7 7 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef42da19_3d38ec57 PS2, Line 106: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c909a8bf_753c7692 PS2, Line 107: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38115b5d_bfadc3b9 PS2, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ed1589a_706654da PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b760cb72_a3453b3a PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a6b65e2_612332ba PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b6115b0_adcf6db6 PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ee4ba3b_287880d5 PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c5fa31_7378eeee PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ecdb68e_e9808715 PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf97ec50_892513b2 PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e222dbd2_ed4895e3 PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eed6c35_0a973f20 PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d0948cd_b292c96b PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8943596_66a67bdc PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94845f1f_b935eb0b PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/956b6c02_139b65a0 PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f6bfeb6_077bedb2 PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63c5991e_c4717c1f PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce099397_ca168d4c PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d754b58d_5bfefe5e PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbf0bb64_f9756a49 PS2, Line 118: }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/961d8fc1_a73ad667 PS2, Line 119: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873a1dba_d200f2a2 PS2, Line 120: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95422e91_3f19ddd9 PS2, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff27cc91_1461eb64 PS2, Line 122: static const unsigned char dummy_burst[] = { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36ae0da7_3f045cec PS2, Line 123: 0, 0, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/879b5961_388aa647 PS2, Line 123: 0, 0, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c00797d_95358a0b PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d5a8a80_fd90a2c6 PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd1075f4_5cff83c7 PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2a4b97c_9e43187c PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50171c05_6dfab3d7 PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c228bba_d8c3de76 PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e8565c2_b02b997e PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1abfca62_583e30bb PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f442f03_51370aaa PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f03dc313_a5abec04 PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/878402f0_fc229acf PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64455f0d_f8d255f9 PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54a92586_a70991bc PS2, Line 130: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac60ebf2_8f0b8a95 PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4ca4dc4_2a760388 PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f295ce7e_53f42c77 PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acea8625_ff46834b PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ce66951_c77ad155 PS2, Line 133: 0, 0, 0, 1, 0, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17b97556_dae5b8b5 PS2, Line 133: 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7ce2887_f6a34c03 PS2, Line 134: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/799ae95a_d92052f2 PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7682f2b2_eda845b8 PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fb59e3_1cc11dce PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cddcbfc_8aead84c PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e24ac8c_41919b0a PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/027f2b3b_efe46ebd PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55446c74_26cbfe0a PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636d416_fdad2bff PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9e599d_ec4dd38d PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b34e81a_71d2d737 PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e2c3034_b8fe905a PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9751a887_aa28f31e PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e253f4ea_84091e9f PS2, Line 141: 0, 0, 0 DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1af75d5a_19901f7e PS2, Line 141: 0, 0, 0 please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eb5c486_afd1501c PS2, Line 142: }; DOS line endings

File Transceiver52M/grgsm_vitac/grgsm_vitac.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be88dbee_64f02d2d PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/24e43cf2_ceb3fcd4 PS2, Line 38: void initvita(); Bad function definition - void initvita() should probably be void initvita(void)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/418b240d_0665c00e PS2, Line 59: std::string fpath; labels should not be indented

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26d0baa1_ad7a73aa PS2, Line 60: std::vector<gr_complex> data; spaces required around that '<' (ctx:VxV)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55eda7ce_8bcea424 PS2, Line 60: std::vector<gr_complex> data; spaces required around that '>' (ctx:VxW)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/545882a2_b11ee329 PS2, Line 60: std::vector<gr_complex> data; labels should not be indented

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89d43193_db4a7a35 PS2, Line 62: }; adding a line without newline at end of file

File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/414f972c_a09c45fc PS2, Line 1: /* -*- c++ -*- */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35c52c00_7eb24dcb PS2, Line 2: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52605bb0_66d592d2 PS2, Line 3: * @file trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/024e5e3c_9984d0b3 PS2, Line 4: * @author (C) 2009-2017 by Piotr Krysik ptrkrysik@gmail.com trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690d3124_521ebc68 PS2, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild ewild@sysmocom.de trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/448b2dff_a2469425 PS2, Line 6: * @section LICENSE trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e67d61e_3ef20283 PS2, Line 7: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1863108_ac01961e PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6009c345_ba1cca39 PS2, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59fee2ad_c52e463b PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b017a4dd_13384a75 PS2, Line 11: * any later version. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6c9cc4_089e20b3 PS2, Line 12: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2823ea35_d4863a9a PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3adebc32_17d57a7f PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a36bef9b_20f8aaad PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df4c37f7_63b9c233 PS2, Line 16: * GNU General Public License for more details. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0191f2f1_854f4f01 PS2, Line 17: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29821671_858398d8 PS2, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23df2001_9ee74458 PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01c8ff98_7486a545 PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc442523_c67eb68c PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bc83e8c_102f3113 PS2, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7cfd5f38_626a9014 PS2, Line 22: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef908324_5f149f2c PS2, Line 23: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9411010_a055c52f PS2, Line 24: #include "constants.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3f1d051_4578f7b6 PS2, Line 25: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821f0200_12e5b643 PS2, Line 26: #ifdef HAVE_CONFIG_H DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0ff4242_172d6d79 PS2, Line 27: #include "config.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58560035_cc5e3d59 PS2, Line 28: #endif DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/150bf6a2_104c50c4 PS2, Line 29: #include <complex> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddd3d058_262ce3cd PS2, Line 30: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af6c70a_66a569f0 PS2, Line 31: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/524c8f78_2e99b604 PS2, Line 32: #include <algorithm> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/002a5d06_9d22588b PS2, Line 33: #include <string.h> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5074fa8_54240036 PS2, Line 34: #include <iostream> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77d6a78_98777dea PS2, Line 35: #include <numeric> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26596589_f455f118 PS2, Line 36: #include <vector> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/603cd00b_04f2600f PS2, Line 37: #include <fstream> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec5624c5_57d407c3 PS2, Line 38: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f180c0c4_e484c429 PS2, Line 39: #include "viterbi_detector.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1074c4e_d0fd73cc PS2, Line 40: #include "grgsm_vitac.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9a53d9c_3c7b3a2f PS2, Line 41: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d3ac5e4_5a7cf572 PS2, Line 42: //signalVector mChanResp; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2624d918_ad6cfe8c PS2, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a99b3e2_0ef376af PS2, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0af2c1ef_589c0d40 PS2, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b442146a_1ff228f6 PS2, Line 46: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/baf47aca_0e69b0fb PS2, Line 47: void initvita() { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/355ebfb4_f65f0257 PS2, Line 48: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69e9c682_ca1f2bde PS2, Line 49: /** trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/413d2a0d_93253d16 PS2, Line 50: * Prepare SCH sequence bits trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/976d7fed_726c2eb3 PS2, Line 51: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa1cb3f2_643051e3 PS2, Line 52: * (TS_BITS + 2 * GUARD_PERIOD) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd789410_9397358f PS2, Line 53: * Burst and two guard periods trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f892b19_4955a7f6 PS2, Line 54: * (one guard period is an arbitrary overlap) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb65aa6b_caf69314 PS2, Line 55: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/256893d4_a92653d1 PS2, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab9e38e4_7c321b41 PS2, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0)); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8521238_c8815857 PS2, Line 58: for (auto &i : d_sch_training_seq) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75af89cb_33263745 PS2, Line 59: i = conj(i); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2ed7679_97d843b0 PS2, Line 60: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2443ef48_8d388084 PS2, Line 61: /* Prepare bits of training sequences */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd068aa_b790207f PS2, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d1b1606_26c6851e PS2, Line 63: /** trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3843da2c_0dfb91eb PS2, Line 64: * If first bit of the sequence is 0 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6feeb70_7f4c46d5 PS2, Line 65: * => first symbol is 1, else -1 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c4dfff3_dd4e7af7 PS2, Line 66: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24bf315_4a8c876e PS2, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ? DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8725c3d_b6e7ff6e PS2, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95a78ea6_511f33d9 PS2, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbf9397_0a24484f PS2, Line 70: d_norm_training_seq[i], startpoint); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250c4b29_aa6aaedc PS2, Line 71: for (auto &i : d_norm_training_seq[i]) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82677a06_557513ac PS2, Line 72: i = conj(i); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f7f7895_9b55f42f PS2, Line 73: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051415d7_20610004 PS2, Line 74: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe559c6_8789bc37 PS2, Line 75: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bde1af7_2da0d626 PS2, Line 76: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e752a8_fd185227 PS2, Line 77: MULTI_VER_TARGET_ATTR DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dd673a8a_6e8bf004 PS2, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d313d663_7219c926 PS2, Line 79: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1f3f745_b65bfb33 PS2, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40eada7b_3cc31d4f PS2, Line 81: unsigned int stop_states[2] = { 4, 12 }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af80762_f7b50378 PS2, Line 82: gr_complex filtered_burst[BURST_SIZE]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea20e96e_5c23e504 PS2, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a42490ef_6a54791c PS2, Line 84: float output[BURST_SIZE]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d00ca77_4b00458b PS2, Line 85: int start_state = 3; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/260bff6e_b7a71c43 PS2, Line 86: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958667ef_6d52aad5 PS2, Line 87: // if(burst_start < 0 ||burst_start > 10) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4b1d67f_8eeb3797 PS2, Line 88: // fprintf(stderr, "bo %d\n", burst_start); trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af752f1f_acece406 PS2, Line 89: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca7f6bc7_319fff9b PS2, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/182e3718_ea84b2f2 PS2, Line 91: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b8d13ac_c133f0eb PS2, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca998df2_6e4343a8 PS2, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26839e07_66b04ae6 PS2, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64381507_7114b0f2 PS2, Line 95: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ea77aa8_d00623a6 PS2, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0b5cf0f_c7928e45 PS2, Line 97: d_chan_imp_length * d_OSR, filtered_burst); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26a426db_552cba2f PS2, Line 98: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/268a3909_4dc38c6c PS2, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7801c01c_952472e2 PS2, Line 100: start_state, stop_states, 2, output); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc385f87_ceb446c9 PS2, Line 101: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71453e24_91275d61 PS2, Line 102: for (int i = 0; i < BURST_SIZE; i++) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d146dcb0_55579480 PS2, Line 103: output_binary[i] = output[i] * -127; // pre flip bits! trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72b27196_f21d45e3 PS2, Line 104: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49ab04fd_3031e28f PS2, Line 105: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63b7bfcd_00817f71 PS2, Line 106: void DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885b8fdc_b64c28a1 PS2, Line 107: gmsk_mapper(const unsigned char* input, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e62acb2_df4037ae PS2, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87b4d812_d65bfb3c PS2, Line 109: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1db0f482_994b3620 PS2, Line 110: gr_complex j = gr_complex(0.0, 1.0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19e16a5f_59ecc68f PS2, Line 111: gmsk_output[0] = start_point; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db65bd6e_2a82e56c PS2, Line 112: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a02c32a_49b1a089 PS2, Line 113: int previous_symbol = 2 * input[0] - 1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de45d096_9312d0ea PS2, Line 114: int current_symbol; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96b60472_1ec5fb14 PS2, Line 115: int encoded_symbol; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dba13ecb_43e29d3e PS2, Line 116: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c042a34_a916a471 PS2, Line 117: for (int i = 1; i < nitems; i++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf27d404_1df990fb PS2, Line 118: /* Change bits representation to NRZ */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df12c1d2_bb46a65e PS2, Line 119: current_symbol = 2 * input[i] - 1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d74045a3_89aaa076 PS2, Line 120: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfb833ff_a5b6b263 PS2, Line 121: /* Differentially encode */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282efc69_f3744197 PS2, Line 122: encoded_symbol = current_symbol * previous_symbol; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bae50c10_7eeee2ae PS2, Line 123: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d12e015_a6f89e7e PS2, Line 124: /* And do GMSK mapping */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e186f540_0473c6e4 PS2, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf9cf2f1_a5c4226a PS2, Line 126: * gmsk_output[i - 1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67833d78_e4e7d82f PS2, Line 127: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c1180c1_9d222749 PS2, Line 128: previous_symbol = current_symbol; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e779bf88_b73bf030 PS2, Line 129: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b24387b0_47fedb76 PS2, Line 130: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496b92b8_7704d56e PS2, Line 131: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57d652d2_b72d3a83 PS2, Line 132: gr_complex DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed8cf6ea_6c9c0d6c PS2, Line 133: correlate_sequence(const gr_complex* sequence, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53e5699a_ce1b60ac PS2, Line 134: int length, const gr_complex* input) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2831fd6f_9ff1a0c4 PS2, Line 135: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cd000d_9a9e6784 PS2, Line 136: gr_complex result(0.0, 0.0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98e40f03_37725da1 PS2, Line 137: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4efae0de_baafa6dd PS2, Line 138: for (int ii = 0; ii < length; ii++) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa27213f_95485964 PS2, Line 139: result += sequence[ii] * input[ii * d_OSR]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e238b207_09d18bfe PS2, Line 140: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bed254c1_b5a1e823 PS2, Line 141: return conj(result) / gr_complex(length, 0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52a38925_c931964b PS2, Line 142: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2f335bc_acfa7c80 PS2, Line 143: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5391e810_4a881e39 PS2, Line 144: /* Computes autocorrelation for positive arguments */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/061df6c3_f78f4d50 PS2, Line 145: inline void DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/269a6671_66eb8fab PS2, Line 146: autocorrelation(const gr_complex* input, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e28a1767_220b7b56 PS2, Line 147: gr_complex* out, int nitems) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c86a3865_be0f9231 PS2, Line 148: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7e4821e_ea02dcb1 PS2, Line 149: for (int k = nitems - 1; k >= 0; k--) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/714af8b8_e289411d PS2, Line 150: out[k] = gr_complex(0, 0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/861ae240_1aade934 PS2, Line 151: for (int i = k; i < nitems; i++) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48454fcd_a49a7ad8 PS2, Line 152: out[k] += input[i] * conj(input[i - k]); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8723254c_207c9f65 PS2, Line 153: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0c0b688_40320990 PS2, Line 154: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56118f00_2314cc8c PS2, Line 155: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71bbbd1d_daa9f13a PS2, Line 156: inline void DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/627159e4_b0b7827c PS2, Line 157: mafi(const gr_complex* input, int nitems, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0039065_fb75f52b PS2, Line 158: gr_complex* filter, int filter_length, gr_complex* output) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8985e34_a1e5ff55 PS2, Line 159: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e974f64_1a29f78c PS2, Line 160: for (int n = 0; n < nitems; n++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/092740d8_6b11f2e5 PS2, Line 161: int a = n * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1acdc928_418bfebd PS2, Line 162: output[n] = 0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/159f3d4f_655091fb PS2, Line 163: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2413335_4bafc558 PS2, Line 164: for (int ii = 0; ii < filter_length; ii++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/833a353a_b8412f76 PS2, Line 165: if ((a + ii) >= nitems * d_OSR) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44ed3846_f2718af5 PS2, Line 166: break; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f5cf3cb_75477e5d PS2, Line 167: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bbd75c4_4c72abc3 PS2, Line 168: output[n] += input[a + ii] * filter[ii]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e48d59ad_09ebf5ef PS2, Line 169: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88364202_7a73291f PS2, Line 170: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d40f189d_bbfd2601 PS2, Line 171: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70c39134_3906d7e2 PS2, Line 172: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c6799b08_f4531c67 PS2, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c84ce_1be5a0eb PS2, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f5db55_bb86a733 PS2, Line 175: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb3feaa_e1b5808f PS2, Line 176: std::vector<gr_complex> correlation_buffer; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8140326_052e1fcb PS2, Line 177: std::vector<float> window_energy_buffer; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ba311ae_3eb6d8aa PS2, Line 178: std::vector<float> power_buffer; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bff55401_940e539a PS2, Line 179: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9b1f6fb_9fad2878 PS2, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ce3fdd2_34f4ae09 PS2, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16653094_93dc0bad PS2, Line 182: correlation_buffer.push_back(correlation); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84249996_8e0fbb40 PS2, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2)); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f912ab75_7572d0b2 PS2, Line 184: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b749561_83bddacd PS2, Line 185: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2022f4c_b075b331 PS2, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae9f362c_da1e75d6 PS2, Line 187: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ab35979_dad3e595 PS2, Line 188: /* Compute window energies */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce9ebad8_75e5f7ea PS2, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f47c97d_3205c122 PS2, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4784eb3_06a0ec01 PS2, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ae9c5f9_00bc90c1 PS2, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0045676a_4a3aa790 PS2, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b76834a_ad9bbfab PS2, Line 194: while (iter != iter_end) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63434c2e_b6762ba6 PS2, Line 195: std::vector<float>::iterator iter_ii = iter; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41b2f892_31454b97 PS2, Line 196: bool loop_end = false; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f2b549e_4a498597 PS2, Line 197: float energy = 0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dca945f4_17ff79c3 PS2, Line 198: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da41dd7_57194058 PS2, Line 199: int len = d_chan_imp_length * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb91881d_4866c120 PS2, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de69bb5_295fd0d5 PS2, Line 201: if (iter_ii == power_buffer.end()) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a556d73e_baef2e14 PS2, Line 202: loop_end = true; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c2491fe_d3915c13 PS2, Line 203: break; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8bb97e2_0ef6c3aa PS2, Line 204: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92ad3608_c22d03bd PS2, Line 205: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57e47f1_3ee849e7 PS2, Line 206: energy += (*iter_ii); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54ed5296_46a5ca02 PS2, Line 207: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0bf516f_c041a695 PS2, Line 208: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8802f83_1b587d46 PS2, Line 209: if (loop_end) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e371f08b_d0f524d6 PS2, Line 210: break; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4be2b31_6782e8b3 PS2, Line 211: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94876ef2_5371db97 PS2, Line 212: window_energy_buffer.push_back(energy); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08e3cd2c_932fae36 PS2, Line 213: iter++; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4697ef3e_c91aca24 PS2, Line 214: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a68dce1e_e96e36ac PS2, Line 215: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb553c3_a1716b49 PS2, Line 216: /* Calculate the strongest window number */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b764f9a_0bbd1f70 PS2, Line 217: int strongest_window_nr = window_energy_start_offset + DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/777c1a1b_cfa20aeb PS2, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f580ec67_a0caa59c PS2, Line 219: window_energy_buffer.begin(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496c7347_6c98f744 PS2, Line 220: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3ae57d8_1ea29abb PS2, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93b12981_00245c08 PS2, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7892d551_89818f51 PS2, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a8cb1e5_75ee557a PS2, Line 224: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab0bdebd_fc004e73 PS2, Line 225: // /* Calculate the strongest window number */ trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9fc476_4f595dd0 PS2, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a0a5a2d_2367151a PS2, Line 227: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94f66c4e_2554ffe4 PS2, Line 228: // if (strongest_window_nr < 0) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76e238be_8cd51982 PS2, Line 229: // strongest_window_nr = 0; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0cf060d_03038705 PS2, Line 230: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93afa4b4_cf3d6abf PS2, Line 231: float max_correlation = 0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3051e531_08dd04d9 PS2, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0759c57d_58ad5339 PS2, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d641dd4_e07c6e1a PS2, Line 234: if (abs(correlation) > max_correlation) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4fe5490_5bcbbf07 PS2, Line 235: max_correlation = abs(correlation); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92be661a_f0122346 PS2, Line 236: chan_imp_resp[ii] = correlation; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2494fc0_0883b8f0 PS2, Line 237: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ca1135_a3da8f02 PS2, Line 238: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86ec2a48_6fd5f09a PS2, Line 239: *corr_max = max_correlation; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec0b0b22_98b6c75a PS2, Line 240: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7a33092_36cb089e PS2, Line 241: /** trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4137c19_13a269b7 PS2, Line 242: * Compute first sample position, which corresponds trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33b25a9f_8de20c52 PS2, Line 243: * to the first sample of the impulse response trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/582dea18_3e3391f3 PS2, Line 244: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32c129c0_84490318 PS2, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb6f4e09_a8c47228 PS2, Line 246: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4fc449d_402026b0 PS2, Line 247: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8af24a92_48418167 PS2, Line 248: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6ed7789_d7bfa7cb PS2, Line 249: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9014e059_f451e92c PS2, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14620605_0226868f PS2, Line 251: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cdce852c_c4e1f717 PS2, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5527936a_47d6a8b1 PS2, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34ecf7b4_789eb48f PS2, Line 254: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11208750_a7712023 PS2, Line 255: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6355c88c_88ff85f3 PS2, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e86cef0_bc5d0c0b PS2, Line 257: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/865ef4c7_7e253669 PS2, Line 258: const int search_center = TRAIN_POS; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d98aa050_39d94067 PS2, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69c970a0_7f14eef9 PS2, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d525bdb1_2e4ae1e3 PS2, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12737bd2_9a8ff5e5 PS2, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8c5efa9_6e04750a PS2, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891eda51_d82b0df4 PS2, Line 264: corr_max); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19ca6a5d_8270cb7d PS2, Line 265: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de4bee85_2a32980e PS2, Line 266: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc1d0a1e_bcc65024 PS2, Line 267: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ebf9bab_25e8a117 PS2, Line 268: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fb8a956_9eb841d7 PS2, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02e25c91_dad5dff6 PS2, Line 270: start 3+39 - 10 trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6973cfcb_2489cb98 PS2, Line 271: end 3+39 + SYNC_SEARCH_RANGE trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0290757_9539734b PS2, Line 272: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/abe61aa0_44f16445 PS2, Line 273: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c432bf57_9fe313c4 PS2, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/311bcd60_2a7404f3 PS2, Line 275: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c4dfd24_f44ee54a PS2, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/295d39db_e64ca420 PS2, Line 277: const int search_start_pos = (search_center - 10) * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207b95df_7f63745f PS2, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08d53b1e_b4f4c219 PS2, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaf3543d_c6ef4e0d PS2, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2131722_3fec9b07 PS2, Line 281: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9828a4_57916d9a PS2, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de6070a_cc197920 PS2, Line 283: float corr_max; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b02f0a4d_4ba86232 PS2, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61eae032_f2422e25 PS2, Line 285: &corr_max); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce71dc8c_ff9f2c08 PS2, Line 286: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa73f80f_1cc9b5a4 PS2, Line 287: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b08fd195_e8d2dc83 PS2, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c64e395b_e11ba70f PS2, Line 289: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6debf3a2_457b711c PS2, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aaf46d9_5cd6bef0 PS2, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5546cf23_214442b2 PS2, Line 292: const int search_start_pos = 0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d53cac52_5160ddeb PS2, Line 293: // FIXME: proper end offset trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c3200bb_33cb53c5 PS2, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b0de97e_d7ceaede PS2, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87277d6_1dfb85a0 PS2, Line 296: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af0b9752_f4498b9e PS2, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c70a6d2_93026856 PS2, Line 298: corr_max); DOS line endings

File Transceiver52M/grgsm_vitac/viterbi_detector.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c623c58_c0fdf09a PS2, Line 1: /* -*- c++ -*- */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62e4e61c_8e99e164 PS2, Line 2: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c3fd98e_81f242d1 PS2, Line 3: * @file trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96ee41c5_198c2259 PS2, Line 4: * @author (C) 2009 Piotr Krysik ptrkrysik@gmail.com trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65306923_e37aec6f PS2, Line 5: * @section LICENSE trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc7ef19d_24846f15 PS2, Line 6: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daf638cf_06adbd31 PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1058463e_3561a26b PS2, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cdc45b_a8d56397 PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4247d286_9c9f4d1d PS2, Line 10: * any later version. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e691bd_028cbbe7 PS2, Line 11: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a44be30d_5e63b8f7 PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da07b282_3ac20db0 PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71a1f95e_469c5408 PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54296cdc_ec311ac3 PS2, Line 15: * GNU General Public License for more details. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26afdaa0_3b3ba30e PS2, Line 16: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62d030d2_69cbd881 PS2, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9726424_33b8311b PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c312bf98_672af5bd PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f393144_f4d26294 PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6b51ab_6269d309 PS2, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f1eec0d_ac189a4d PS2, Line 21: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90dc07cf_1b003cb9 PS2, Line 22: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72982f62_4c5e3939 PS2, Line 23: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b32792aa_2e5acd51 PS2, Line 24: * viterbi_detector: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec21bbd_8e19c4e9 PS2, Line 25: * This part does the detection of received sequnece. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3ec68b_15482483 PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dcfa1c0_c12b1d27 PS2, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f41fb318_dd3e0e98 PS2, Line 28: * it was designed with soft decisions in mind. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3380678e_9969a396 PS2, Line 29: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a86421d_9df44925 PS2, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ae4ee04_572057b5 PS2, Line 31: * const gr_complex * input, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3babcb2_80b89762 PS2, Line 32: * unsigned int samples_num, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59602858_27701523 PS2, Line 33: * gr_complex * rhh, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d191940a_bd1dcde3 PS2, Line 34: * unsigned int start_state, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5081b459_c41e56eb PS2, Line 35: * const unsigned int * stop_states, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ab9fc1e_0336a56f PS2, Line 36: * unsigned int stops_num, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4026303c_fe3c548f PS2, Line 37: * float * output) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f40ff196_9c38e19a PS2, Line 38: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/238e86e9_07eb6085 PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0f555c1_fab23b8a PS2, Line 40: * samples_num: Number of samples in the input table. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6e76f5c_0df1dfb5 PS2, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/498e2e6c_495bb13b PS2, Line 42: * impulse response. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10094083_3c1e4ed9 PS2, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3434cf36_2042d0ad PS2, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5dff827_a04b89ef PS2, Line 45: * indicates start point of the algorithm. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5dc2ba9_818d54cc PS2, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbf3db56_9575815d PS2, Line 47: * stops_num: Number of possible stop states trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11563be0_a398d71c PS2, Line 48: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fb660a6_4f3ff1e4 PS2, Line 49: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb8a9aa_52b777ca PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3eb6493_77d13bbe PS2, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5442ea1a_4db31ec7 PS2, Line 52: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30653fc6_eea5a15a PS2, Line 53: * SUB_FUNC: none trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e53ebee_cb8bf546 PS2, Line 54: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/745e22bf_afa178f4 PS2, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f11dfb5_ee380245 PS2, Line 56: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f3554f2_6d1166f8 PS2, Line 57: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3359007f_1e8bd124 PS2, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b31f3e7_40c7f991 PS2, Line 59: #define INCLUDED_VITERBI_DETECTOR_H DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6607c979_b07f2b5e PS2, Line 60: #include "constants.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7179b3c5_adcfa63e PS2, Line 61: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57c1458_0d26e29a PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f576c6cd_efbb80e1 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d72bc681_36d95fa0 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc160b85_0abaff67 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0bae58b_0ff87a04 PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a9e1404_75a5ad4c PS2, Line 63: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de93af2d_57d46b2f PS2, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */ DOS line endings

File Transceiver52M/grgsm_vitac/viterbi_detector.cc:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04ebde_021355b1 PS2, Line 1: /* -*- c++ -*- */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a431b13_eec16fe6 PS2, Line 2: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4219d9b7_e0762416 PS2, Line 3: * @file trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636539c_c16bd9dd PS2, Line 4: * @author (C) 2009 by Piotr Krysik ptrkrysik@gmail.com trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b43e870b_1b8bc300 PS2, Line 5: * @section LICENSE trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad47af75_bb369bd1 PS2, Line 6: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/302452d9_7068813c PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9faa189_631fcaa9 PS2, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/698f579e_a7e41d89 PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2825f863_add84186 PS2, Line 10: * any later version. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bf03c30_486be42f PS2, Line 11: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e8f9397_fc88951d PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d70d8d1_3b853e31 PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5082c09e_fabf5a5d PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03f5ef18_afeee957 PS2, Line 15: * GNU General Public License for more details. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64b876d0_aa28dbad PS2, Line 16: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/253fbf55_9e7e913a PS2, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc8c3b45_97a62634 PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4707db8c_640434d6 PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0048b50f_600146fc PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b64ed7_20c46039 PS2, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd15f62_419668a7 PS2, Line 21: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6faa9390_e54fdeb0 PS2, Line 22: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7f09e61_eb32c883 PS2, Line 23: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/819830e9_77271fad PS2, Line 24: * viterbi_detector: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f33c0a4_f9c2a63d PS2, Line 25: * This part does the detection of received sequnece. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70ed75e5_fd56f0ce PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3b9a521_8eeb10b5 PS2, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5238d8cc_fc89be97 PS2, Line 28: * it was designed with soft decisions in mind. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a449fa2_4afe32f5 PS2, Line 29: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72f9cb76_08edd544 PS2, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf53c04a_95eb0e34 PS2, Line 31: * const gr_complex * input, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b95b1ef_8a6b7fa3 PS2, Line 32: * unsigned int samples_num, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2ec3ed5_accf841a PS2, Line 33: * gr_complex * rhh, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d816e8d1_05a19314 PS2, Line 34: * unsigned int start_state, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3ef5b49_55eef8ec PS2, Line 35: * const unsigned int * stop_states, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/173b18a6_e8ba9a47 PS2, Line 36: * unsigned int stops_num, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4560e92f_5a51130f PS2, Line 37: * float * output) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e4b0ed_499c3711 PS2, Line 38: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e179d493_56a83d13 PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/400048fe_225efc5b PS2, Line 40: * samples_num: Number of samples in the input table. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33e85216_6a042029 PS2, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2065c050_1f449b62 PS2, Line 42: * impulse response. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dc8cbed_51c44c63 PS2, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da706529_3364054b PS2, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef7e7360_538afd74 PS2, Line 45: * indicates start point of the algorithm. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be9af8a0_f20bdd2c PS2, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e5974ed_19688c0d PS2, Line 47: * stops_num: Number of possible stop states trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e981ad7_ff67e430 PS2, Line 48: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/440cb688_0f8ac430 PS2, Line 49: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7433065_91d84f39 PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d10c90bc_5cda359f PS2, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61a7fc74_df3dc71f PS2, Line 52: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/674feb0f_c509ce51 PS2, Line 53: * SUB_FUNC: none trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a29e3309_51edde61 PS2, Line 54: * trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eca89a1_d74c8149 PS2, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/22922396_79c81b7f PS2, Line 56: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6abf775e_4c383d37 PS2, Line 57: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cb97103_7691b881 PS2, Line 58: #include "constants.h" DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c4694fa_31366f4b PS2, Line 59: #include <cmath> DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78b017cf_26837483 PS2, Line 60: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf72937c_7e47f63f PS2, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4318937_f714b726 PS2, Line 62: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9667a00_60f1e1ac PS2, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74d62202_10cf182f PS2, Line 64: { DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/916aa0ac_7022bb34 PS2, Line 65: float increment[8]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c72e77a_263ea8cd PS2, Line 66: float path_metrics1[16]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ade2a744_b2967a60 PS2, Line 67: float path_metrics2[16]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f5621f2_218a2f57 PS2, Line 68: float paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0976f82d_790cf349 PS2, Line 69: float * new_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12cbc750_aa0ede7b PS2, Line 70: float * old_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6e10f09_afbddd57 PS2, Line 71: float * tmp; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f2afbe1_d132b2e1 PS2, Line 72: float trans_table[BURST_SIZE][16]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a53a87a0_81007f3c PS2, Line 73: float pm_candidate1, pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21c3c1cf_048f5163 PS2, Line 74: bool real_imag; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/949431f6_f87e28f6 PS2, Line 75: float input_symbol_real, input_symbol_imag; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4731ace7_76164040 PS2, Line 76: unsigned int i, sample_nr; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c46db8b_609c49f7 PS2, Line 77: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0ccdada_b1c7ed08 PS2, Line 78: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/950b203a_d8dd0ffe PS2, Line 79: * Setup first path metrics, so only state pointed by start_state is possible. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e219638_8b015bcf PS2, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value, trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c337127_85f31b66 PS2, Line 81: * which makes them practically impossible to occur. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373100ff_f11a3d10 PS2, Line 82: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f930d391_bfdcbeca PS2, Line 83: for(i=0; i<PATHS_NUM; i++){ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5ec0073_10cac1f3 PS2, Line 84: path_metrics1[i]=(-10e30); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0245da7_f9792bd6 PS2, Line 85: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47dd04d1_8497190b PS2, Line 86: path_metrics1[start_state]=0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0112194c_bd10946e PS2, Line 87: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92cfd1fe_5463ab3b PS2, Line 88: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf0b0f74_7e685184 PS2, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ebd52c2_71ee14f1 PS2, Line 90: * Increment is table of reference levels for computation of branch metrics: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d91e1a5f_be13f94b PS2, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1db81eb_cce51d50 PS2, Line 92: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f2fd93_0f0cb2c6 PS2, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6044b24_ca43e4ce PS2, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c24cb3d6_3aea0d79 PS2, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21537003_08aec9b4 PS2, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf830e57_881eab32 PS2, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ceeab1b9_06399b64 PS2, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9270e46b_a749e5f5 PS2, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d31a486_40e1b822 PS2, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23ccb7bd_f623b229 PS2, Line 101: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885e927a_2731f854 PS2, Line 102: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efba4f87_7673f91c PS2, Line 103: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c21fbd8a_0ab720a4 PS2, Line 104: * Computation of path metrics and decisions (Add-Compare-Select). trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ed35a0d_ffb4480b PS2, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers) trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0db49c31_065f5664 PS2, Line 106: * and one for even samples (real numbers). trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad811fd2_e0401fb1 PS2, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4515d5a1_d6494e00 PS2, Line 108: * this one: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6f057d3_f4035507 PS2, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fccf7f_f41ce239 PS2, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41d84f3_5f11f6f1 PS2, Line 111: * paths_difference=pm_candidate2-pm_candidate1; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88b5a4ca_6fc721a5 PS2, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb03c87_780f3a83 PS2, Line 113: * trans_table[sample_nr][1] = paths_difference; trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adbe8da2_2b59ab4d PS2, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bac61b7e_d79773cc PS2, Line 115: * consuming part of this function. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbb3284_ac44977b PS2, Line 116: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fd32232_02e29f44 PS2, Line 117: sample_nr=0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ef22a13_98332cef PS2, Line 118: old_path_metrics=path_metrics1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8115928_ac827029 PS2, Line 119: new_path_metrics=path_metrics2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e70dd00_53702bb8 PS2, Line 120: while(sample_nr<samples_num){ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6be6c1b_d9c8858a PS2, Line 121: //Processing imag states trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873052bb_7877e6f9 PS2, Line 122: real_imag=1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a87ab81_abf9008e PS2, Line 123: input_symbol_imag = input[sample_nr].imag(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2f5347e_ba57be00 PS2, Line 124: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1d93d15_e14a5c0f PS2, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/029985b5_6da858aa PS2, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05ddeca5_4cc99647 PS2, Line 127: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18fa8fa4_430cfc3e PS2, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0389fc2d_b1d38a6c PS2, Line 129: trans_table[sample_nr][0] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ed2e100_c5712e74 PS2, Line 130: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa43bfa5_1bef1ec0 PS2, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c410bc06_df85fec8 PS2, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11d2c1c0_be4d4117 PS2, Line 133: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a038a491_0eb2b56a PS2, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1df2f367_7db04406 PS2, Line 135: trans_table[sample_nr][1] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6b26d22_ec7a5990 PS2, Line 136: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b844d20_f5cf3307 PS2, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efafc8e6_c715772d PS2, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64a7cdbf_1646a64a PS2, Line 139: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf16e85d_1cd1a8d2 PS2, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc668099_63e3f026 PS2, Line 141: trans_table[sample_nr][2] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02aacb14_16f5471f PS2, Line 142: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bce688e9_304a2fb7 PS2, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2beb671_be61ec4e PS2, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ac89e4a_3238ffe1 PS2, Line 145: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1efe3799_1a8011e7 PS2, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f94f9a5_34dd0f01 PS2, Line 147: trans_table[sample_nr][3] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff854304_d1afffb6 PS2, Line 148: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdffc65b_21a25693 PS2, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6835d625_d32a45d9 PS2, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e85a381b_9a022197 PS2, Line 151: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99afc4db_48e98fa0 PS2, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb72145_4c978279 PS2, Line 153: trans_table[sample_nr][4] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec2dedcc_943427c4 PS2, Line 154: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1220705_55996237 PS2, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e5e85ad_edf99f86 PS2, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5a285f5_da5d865e PS2, Line 157: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a58023f_5980b528 PS2, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6151009e_ec46b8b1 PS2, Line 159: trans_table[sample_nr][5] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bf3fcea_5e9339ef PS2, Line 160: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebcf668b_ddaa27f5 PS2, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f52903_24cc297f PS2, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345668b4_5d192e69 PS2, Line 163: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958874f9_e25d3931 PS2, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b15f89e_6531789c PS2, Line 165: trans_table[sample_nr][6] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56d0ef03_f45df79d PS2, Line 166: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/642d74d6_9772f8b6 PS2, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9504855_b2e8e3df PS2, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b25c7f6_e2432f0a PS2, Line 169: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e529294d_4d43dc47 PS2, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f9d5c10_f47e594e PS2, Line 171: trans_table[sample_nr][7] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9c5fdd6_b0de5144 PS2, Line 172: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fd9bb89_c0c1f782 PS2, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b5b6fd1_1a2d1383 PS2, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04b7ef_045a9e47 PS2, Line 175: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/023767aa_72930671 PS2, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80d9ca01_c3c1f88f PS2, Line 177: trans_table[sample_nr][8] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd6f7496_8006f729 PS2, Line 178: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0541ae1_249039d3 PS2, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b58c726e_22292867 PS2, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a50b68f6_bdd0c431 PS2, Line 181: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42232426_cf18fdf3 PS2, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4647c84_211baf75 PS2, Line 183: trans_table[sample_nr][9] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c111e70_c8196225 PS2, Line 184: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f66120cd_0e6cec5e PS2, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9abbff0_b2828809 PS2, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa5bc56_0a1a9d20 PS2, Line 187: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c82db_53342f73 PS2, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/052f0983_f5391273 PS2, Line 189: trans_table[sample_nr][10] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3856ca77_9e6eeac7 PS2, Line 190: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9ddcc1d_6d5d6de9 PS2, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32856c54_4261b11a PS2, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf89f191_98b66baf PS2, Line 193: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2cb3a4c_03fdb1c4 PS2, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/384e1cec_4abe3c19 PS2, Line 195: trans_table[sample_nr][11] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/832bde5f_3fa895f4 PS2, Line 196: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c71accad_7aa4f17f PS2, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/431c699a_58fde763 PS2, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/008c2851_c2e3bd30 PS2, Line 199: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bde6818d_7d2bcbc5 PS2, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4873a45_de170cab PS2, Line 201: trans_table[sample_nr][12] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7f5b567_9e763355 PS2, Line 202: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba826ad8_977cb4fb PS2, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63e065dc_dfedeadc PS2, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f816db_f7ec9eda PS2, Line 205: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd973d7c_bb7f431e PS2, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9d5c04d_6820a079 PS2, Line 207: trans_table[sample_nr][13] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cca0e12_54d46a36 PS2, Line 208: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/402ca9e8_d981ec51 PS2, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc178b3a_135732af PS2, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0790d2c_90c81d65 PS2, Line 211: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3210f2ef_9e88e7d2 PS2, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a099896_b7866b7b PS2, Line 213: trans_table[sample_nr][14] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27cc067_cda544ab PS2, Line 214: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95413569_b37b5680 PS2, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58d15de8_7a9d1785 PS2, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90f2557d_3c4dc985 PS2, Line 217: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69b52a4a_37a500a5 PS2, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87bc80ab_9a69f0c7 PS2, Line 219: trans_table[sample_nr][15] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/000bc266_dda2bd18 PS2, Line 220: tmp=old_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b69ce3_8fe4e952 PS2, Line 221: old_path_metrics=new_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e6465af_83597879 PS2, Line 222: new_path_metrics=tmp; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6308b1c2_dd1d00f6 PS2, Line 223: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41b0e9d_dfa524af PS2, Line 224: sample_nr++; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b459f88_b8e14e0c PS2, Line 225: if(sample_nr==samples_num) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dca96db_50d41d85 PS2, Line 226: break; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0a258bf_9e024e07 PS2, Line 227: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a179653a_b6d6209b PS2, Line 228: //Processing real states trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f48596e_18a54a12 PS2, Line 229: real_imag=0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d0b8d38_18081dff PS2, Line 230: input_symbol_real = input[sample_nr].real(); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e013d597_1d5bc2b2 PS2, Line 231: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/422ab2ce_836df58f PS2, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94d46ddc_09221c27 PS2, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb3655b_5824d3ad PS2, Line 234: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bbee17e_24615ead PS2, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8310ff7_b268fe45 PS2, Line 236: trans_table[sample_nr][0] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72bdb613_51f34cda PS2, Line 237: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adf152bb_bdc51703 PS2, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffca4a6b_5a2fd9d0 PS2, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27a7547_88765d61 PS2, Line 240: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebc47d61_67ff024b PS2, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff6b3f6f_2cc54f19 PS2, Line 242: trans_table[sample_nr][1] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0d84634_c99680ee PS2, Line 243: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1743cfa_3cd62672 PS2, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26e7f107_2c30d37a PS2, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de5b7134_58ea690b PS2, Line 246: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2672c2d_1d41f8df PS2, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb64a506_15fcaafb PS2, Line 248: trans_table[sample_nr][2] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/902337c9_b1d96948 PS2, Line 249: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e1c734_5b77d082 PS2, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3719268c_69a3a6ab PS2, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1523674_4cb730d5 PS2, Line 252: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec9c2d7b_815dde6a PS2, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bea1baa_3d35353d PS2, Line 254: trans_table[sample_nr][3] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02695e48_ec196933 PS2, Line 255: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3816ffac_b1926cc0 PS2, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051002a5_12c91e62 PS2, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd957a9_62dcc2f1 PS2, Line 258: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf7b5c94_a24b81d5 PS2, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41724c00_5eca79c8 PS2, Line 260: trans_table[sample_nr][4] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b0c90fc_ded4dd39 PS2, Line 261: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30403e4f_cc0baca1 PS2, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e1a9b51_bd580567 PS2, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e37ced_1fa6167a PS2, Line 264: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29e1699e_b996cb80 PS2, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ac6212b_002a8334 PS2, Line 266: trans_table[sample_nr][5] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891b46d8_6bad8f7d PS2, Line 267: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc44745a_a0a3076f PS2, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/407d7d21_af3f550b PS2, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7de9d0c9_645887bf PS2, Line 270: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eee8f66_de3ad06e PS2, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/929247d8_8f3f60c5 PS2, Line 272: trans_table[sample_nr][6] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/935f7535_aab102ce PS2, Line 273: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c4cdade_71d5b744 PS2, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e7dd481_205f5843 PS2, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff36c88a_607bb23e PS2, Line 276: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67535253_561455a1 PS2, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f26094ce_7c68b072 PS2, Line 278: trans_table[sample_nr][7] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec1a6e4_37049d53 PS2, Line 279: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efe86f61_e1328a74 PS2, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30f8f786_0fed0194 PS2, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6167440_d6acf2e9 PS2, Line 282: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53ed12e1_1997c1f0 PS2, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86479557_230eda83 PS2, Line 284: trans_table[sample_nr][8] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43ed253e_bee8e6f4 PS2, Line 285: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/868e1fab_3e437966 PS2, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f3055e2_38426aa6 PS2, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/160db78f_faa37840 PS2, Line 288: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12ca9f4b_2ad940a3 PS2, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68732a27_23023b7b PS2, Line 290: trans_table[sample_nr][9] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f80bf6a9_fde1b085 PS2, Line 291: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fa8470f_cf09cd1f PS2, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5066ea20_0c370212 PS2, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3bd491c_a132d42d PS2, Line 294: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93f9709a_1c5955ee PS2, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f1be962_5605a657 PS2, Line 296: trans_table[sample_nr][10] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea1fba33_d2a6de41 PS2, Line 297: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7977a4f4_f89c014d PS2, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad334b06_82b81949 PS2, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/424b1f8f_6dd578b2 PS2, Line 300: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b6ba883_4b3df351 PS2, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89805ac3_ca3b9672 PS2, Line 302: trans_table[sample_nr][11] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db8e6784_a276158f PS2, Line 303: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f6ea85a_f0f04c68 PS2, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0d10a7c_0e5bc7dd PS2, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a07571a5_55f5d0c3 PS2, Line 306: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcffd453_8f706ea8 PS2, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2264f1b9_ac92c0f2 PS2, Line 308: trans_table[sample_nr][12] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd8be14_6e9d0a9e PS2, Line 309: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21f34d2b_f0c05478 PS2, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd4b69f7_f9e71ef2 PS2, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b2cf3b_032ceec4 PS2, Line 312: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f7660db_ecae6c32 PS2, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e1cec17_c647d4ca PS2, Line 314: trans_table[sample_nr][13] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/293c4368_e2478eb2 PS2, Line 315: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0ffbb9c_ae321365 PS2, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/996edd06_3a152812 PS2, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d50fb25b_bd46a4c6 PS2, Line 318: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8cd001c6_f81632e9 PS2, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690449f9_2e937c84 PS2, Line 320: trans_table[sample_nr][14] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11958998_d3745c7c PS2, Line 321: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a340d57b_03ec149c PS2, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e70d9e6_1c063e49 PS2, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1741b036_b9939b86 PS2, Line 324: paths_difference=pm_candidate2-pm_candidate1; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4abd28b_31a4acd7 PS2, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93578efd_801dc9b4 PS2, Line 326: trans_table[sample_nr][15] = paths_difference; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9caa6199_6f7a306c PS2, Line 327: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dd50192_ef818950 PS2, Line 328: tmp=old_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aa72876_dfd6e0d4 PS2, Line 329: old_path_metrics=new_path_metrics; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74351c9e_ae59317e PS2, Line 330: new_path_metrics=tmp; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ef084d9_1f34fbbc PS2, Line 331: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0e48429_fe9a4a95 PS2, Line 332: sample_nr++; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207372f9_a3eef8df PS2, Line 333: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf29e22e_1ba94a7a PS2, Line 334: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/235a0004_267c78e0 PS2, Line 335: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2eae96b2_f90b55cd PS2, Line 336: * Find the best from the stop states by comparing their path metrics. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4445792b_62709909 PS2, Line 337: * Not every stop state is always possible, so we are searching in trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7ee8ea8_12b85e24 PS2, Line 338: * a subset of them. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24188f9_b592a6db PS2, Line 339: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bec72de_2287a20e PS2, Line 340: unsigned int best_stop_state; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10f4d59d_25d24d33 PS2, Line 341: float stop_state_metric, max_stop_state_metric; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c92ba95_06ffdc57 PS2, Line 342: best_stop_state = stop_states[0]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f96e79d_a93f361a PS2, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce538895_18ffb4ed PS2, Line 344: for(i=1; i< stops_num; i++){ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a49b47cf_8bb6401c PS2, Line 345: stop_state_metric = old_path_metrics[stop_states[i]]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fa6f8bb_0b459d13 PS2, Line 346: if(stop_state_metric > max_stop_state_metric){ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7db4a93b_c8f066f3 PS2, Line 347: max_stop_state_metric = stop_state_metric; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb7f996_c8a1c40a PS2, Line 348: best_stop_state = stop_states[i]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31a8984b_baecd700 PS2, Line 349: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/119c92ca_da35633a PS2, Line 350: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ca0630e_8aba8405 PS2, Line 351: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64662e52_eda4fd69 PS2, Line 352: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f8ac0a0_c769eff4 PS2, Line 353: * This table was generated with hope that it gives a litle speedup during trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d651cda3_9533d5f8 PS2, Line 354: * traceback stage. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f092de25_8e09ee1e PS2, Line 355: * Received bit is related to the number of state in the trellis. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51c332b0_4755c715 PS2, Line 356: * I've numbered states so their parity (number of ones) is related trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/784c0511_54a67d37 PS2, Line 357: * to a received bit. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d4d08ba_c3006891 PS2, Line 358: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca702d3e_27533fb2 PS2, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/011155be_e253073c PS2, Line 360: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e41c12b9_b6a91ac0 PS2, Line 361: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b24edb7_b3e304c1 PS2, Line 362: * Table of previous states in the trellis diagram. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66bf3ffd_514f1885 PS2, Line 363: * For GMSK modulation every state has two previous states. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b684734e_f0143d49 PS2, Line 364: * Example: trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9c71f3_c9b52bfe PS2, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0] trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5cde8d6_3596a3b6 PS2, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1] trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a022fdd8_cac044ea PS2, Line 367: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc469627_408067fb PS2, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e7acd2_14bbf0de PS2, Line 369: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0742122_ec51659b PS2, Line 370: /* trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af121191_d21f5098 PS2, Line 371: * Traceback and differential decoding of received sequence. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/342ce7d2_53141672 PS2, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis. trailing whitespace

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58c19bcc_b7af9b7b PS2, Line 373: */ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d86a2985_82aae718 PS2, Line 374: sample_nr=samples_num; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad04b727_fee3ea90 PS2, Line 375: unsigned int state_nr=best_stop_state; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6befa393_038b9c8e PS2, Line 376: unsigned int decision; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a5330b0_66e9578d PS2, Line 377: bool out_bit=0; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f73019_6f742e81 PS2, Line 378: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e8c31e6_845867ea PS2, Line 379: while(sample_nr>0){ DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/049b4662_f2e1868e PS2, Line 380: sample_nr--; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8508af6e_57e34af4 PS2, Line 381: decision = (trans_table[sample_nr][state_nr]>0); DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c251cf75_e1da3f2d PS2, Line 382: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9abcadd9_a1a93e07 PS2, Line 383: if(decision != out_bit) DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16f86cd9_66152f86 PS2, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2467bf22_49e9fbf9 PS2, Line 385: else DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e3dec2f3_39e89f36 PS2, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c4e5e3_041bddc8 PS2, Line 387: DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce87ba0e_170a4348 PS2, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a7dbab3_cf2cb96f PS2, Line 389: state_nr = prev_table[state_nr][decision]; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da62953_37a882f5 PS2, Line 390: real_imag = !real_imag; DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b88674a_a078a257 PS2, Line 391: } DOS line endings

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54f75c2_997b5000 PS2, Line 392: } DOS line endings