Attention is currently required from: fixeria.
dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37643?usp=email )
Change subject: ara_m: add export support for the ARA-M application
......................................................................
Patch Set 2:
(2 comments)
File pySim/ara_m.py:
https://gerrit.osmocom.org/c/pysim/+/37643/comment/67788b88_0aa4aab3?usp=em… :
PS1, Line 430: if res_do:
Too much nesting here, this is making the code harder
to read/edit. […]
Done
https://gerrit.osmocom.org/c/pysim/+/37643/comment/c9fd1645_4c6beafd?usp=em… :
PS1, Line 432: if 'response_all_ref_ar_do' in res_do_dict and
res_do_dict['response_all_ref_ar_do']:
``` […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37643?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43
Gerrit-Change-Number: 37643
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 13:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>