Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email ) Change subject: update to MNCC V8 support ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File mncc.h: https://gerrit.osmocom.org/c/mncc-python/+/36320/comment/87d5fadc_67f9ef69 PS3, Line 320: struct osmo_gcr_parsed gcr; This does not match the current state of osmo-msc.git (HEAD @ b03001199a99a67f72846b6eba169eb4064a932c): ``` 170 unsigned char lchan_type; 171 unsigned char lchan_mode; 172 173 /* Global Call Reference (encoded as per 3GPP TS 29.205) */ 174 uint8_t gcr[16]; 175 176 /* A buffer to contain SDP ('\0' terminated) */ 177 char sdp[1024]; ``` AFAIR, it was Keith's early attempt to implement passing GCR using an unpacked struct, but then we changed the MNCC protocol to carry a buffer encoded as per 3GPP TS 29.205. -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ia27956e42c6c2f494d59b89f42345462c86b10d2 Gerrit-Change-Number: 36320 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 08:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment