Attention is currently required from: pespin, msuraev.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32628 )

Change subject: trxcon/l1sched: allocate primitives of fixed size (64 + 64) ......................................................................

Patch Set 1:

(2 comments)

File src/host/trxcon/src/sched_prim.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/32628/comment/5db29d35_45147451 PS1, Line 39: #define L1SCHED_PRIM_TAILROOM 64

Where does this come from? Why 64?

Just a reasonable tailroom size, enough to fit GSM and GPRS MAC blocks. Do you have a better idea what the size should be?

https://gerrit.osmocom.org/c/osmocom-bb/+/32628/comment/74df700b_655a3389 PS1, Line 69: msg = msgb_alloc_headroom(L1SCHED_PRIM_HEADROOM + L1SCHED_PRIM_TAILROOM,

shouldn't this L1SCHED_PRIM_TAILROOM actually be sizeof(l1sched_prim) or alike?

Nope. The `struct l1sched_prim` gets *pushed* to headroom (see above). This allows easily dropping the l1sched specific header and pushing another (e.g. l1gprs specific) header in front of the actual data (tailroom).