Attention is currently required from: pespin, msuraev.

View Change

2 comments:

• File src/host/trxcon/src/sched_prim.c:

  • Patch Set #1, Line 39: #define L1SCHED_PRIM_TAILROOM 64

    Where does this come from? Why 64?

    Just a reasonable tailroom size, enough to fit GSM and GPRS MAC blocks.
    Do you have a better idea what the size should be?

  • Patch Set #1, Line 69: msg = msgb_alloc_headroom(L1SCHED_PRIM_HEADROOM + L1SCHED_PRIM_TAILROOM,

    shouldn't this L1SCHED_PRIM_TAILROOM actually be sizeof(l1sched_prim) or alike?

    Nope. The `struct l1sched_prim` gets *pushed* to headroom (see above). This allows easily dropping the l1sched specific header and pushing another (e.g. l1gprs specific) header in front of the actual data (tailroom).

To view, visit change 32628. To unsubscribe, or for help writing mail filters, visit settings.