Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41685?usp=email )

Change subject: logging: change gsmtap target to use wqueue by default ......................................................................

Patch Set 1:

(1 comment)

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/41685/comment/b51d971e_7d41e010?u... : PS1, Line 1047: if (tgt->tgt_gsmtap.ofd_wq_mode)

You don't need here the new field tgt->tgt_gsmtap.ofd_wq_mode: […]

I would do exactly that if `struct gsmtap_inst` were public, but it's not. It's an opaque struct for us here and we cannot access its fields.