[M] Change in osmo-bsc[master]: Includes: Remove enum defs, instead include them - gerrit-log

3 Mar 2023


      Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31304 )
Change subject: Includes: Remove enum defs, instead include them
......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31304/comment/522ed9ff_1adb7ab1 
PS1, Line 654: enum gprs_cs {
...
AFAICT this is only used internally and never sent into the wire. […]
This enum pretty much already exists in `libosmocore/include/osmocom/gsm/protocol/gsm_44_060.h`. What's the reason not to use it?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31304
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2883aee12b501a717d5acecd5638882724336e72
Gerrit-Change-Number: 31304
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 23:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment