osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email ) Change subject: src/rspro_client_fsm: fix osmo_stream_cli_destroy ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @pespin@sysmocom.de: is this the proper way to fix this? for reference, the trace: ``` Program terminated with signal SIGABRT, Aborted. #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44 #0 __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44 #1 __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89 #3 0x00007ccc71e4527e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #4 0x00007ccc71e288ff in __GI_abort () at ./stdlib/abort.c:79 #5 0x00007ccc72227be2 in osmo_panic_default (fmt=0x7ccc7233e60c "Assert failed %s %s:%d\n", args=0x7ffd6c845160) at ../../../src_copy/libosmocore/src/core/panic.c:45 #6 0x00007ccc72227cc2 in osmo_panic (fmt=0x7ccc7233e60c "Assert failed %s %s:%d\n") at ../../../src_copy/libosmocore/src/core/panic.c:80 #7 0x00007ccc72334ea2 in osmo_stream_cli_destroy (cli=0x5fed47a41ca0) at ../../src_copy/libosmo-netif/src/stream_cli.c:1023 #8 0x00005fed1ca12b56 in srvc_allstate_action (fi=0x5fed47a3dc80, event=1, data=0x0) at ../../../src_copy/osmo-remsim/src/client/../rspro_client_fsm.c:537 #9 0x00007ccc722143e3 in _osmo_fsm_inst_dispatch (fi=0x5fed47a3dc80, event=1, data=0x0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=154) at ../../../src_copy/libosmocore/src/core/fsm.c:863 #10 0x00005fed1ca0e366 in main_st_unconfigured_onenter (fi=0x5fed47a3d720, prev_state=3) at ../../../src_copy/osmo-remsim/src/client/main_fsm.c:154 #11 0x00007ccc72213a1f in state_chg (fi=0x5fed47a3d720, new_state=1, keep_timer=false, timeout_ms=0, T=0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=253) at ../../../src_copy/libosmocore/src/core/fsm.c:697 #12 0x00007ccc72213a9a in _osmo_fsm_inst_state_chg (fi=0x5fed47a3d720, new_state=1, timeout_secs=0, T=0, file=0x5fed1ca13bf8 "../../../src_copy/osmo-remsim/src/client/main_fsm.c", line=253) at ../../../src_copy/libosmocore/src/core/fsm.c:746 #13 0x00005fed1ca0eae0 in main_st_operational (fi=0x5fed47a3d720, event=2, data=0x5fed47a40a80) at ../../../src_copy/osmo-remsim/src/client/main_fsm.c:253 #14 0x00007ccc722146de in _osmo_fsm_inst_dispatch (fi=0x5fed47a3d720, event=2, data=0x5fed47a40a80, file=0x5fed1ca13720 "../../../src_copy/osmo-remsim/src/client/remsim_client.c", line=129) at ../../../src_copy/libosmocore/src/core/fsm.c:875 #15 0x00005fed1ca0d5b9 in srvc_handle_rx (srvc=0x5fed47a3d020, pdu=0x5fed47a40a80) at ../../../src_copy/osmo-remsim/src/client/remsim_client.c:129 #16 0x00005fed1ca11426 in srvc_read_cb (cli=0x5fed47a3ff80, res=35, msg=0x5fed47a42830) at ../../../src_copy/osmo-remsim/src/client/../rspro_client_fsm.c:261 #17 0x00007ccc72333e69 in stream_cli_iofd_read_cb (iofd=0x5fed47a40e60, res=35, msg=0x5fed47a42830) at ../../src_copy/libosmo-netif/src/stream_cli.c:569 #18 0x00007ccc7222591e in iofd_handle_segmented_read (iofd=0x5fed47a40e60, msg=0x5fed47a42830, rc=35) at ../../../src_copy/libosmocore/src/core/osmo_io.c:350 #19 0x00007ccc72225a25 in iofd_handle_recv (iofd=0x5fed47a40e60, msg=0x5fed47a42830, rc=35, hdr=0x0) at ../../../src_copy/libosmocore/src/core/osmo_io.c:377 #20 0x00007ccc72227561 in iofd_poll_ofd_cb_recvmsg_sendmsg (ofd=0x5fed47a40f10, what=1) at ../../../src_copy/libosmocore/src/core/osmo_io_poll.c:64 #21 0x00007ccc722279bb in iofd_poll_ofd_cb_dispatch (ofd=0x5fed47a40f10, what=1) at ../../../src_copy/libosmocore/src/core/osmo_io_poll.c:136 #22 0x00007ccc7222b040 in poll_disp_fds (n_fd=3) at ../../../src_copy/libosmocore/src/core/select.c:419 #23 0x00007ccc7222b15a in _osmo_select_main (polling=0) at ../../../src_copy/libosmocore/src/core/select.c:457 #24 0x00007ccc7222b179 in osmo_select_main (polling=0) at ../../../src_copy/libosmocore/src/core/select.c:496 #25 0x00005fed1ca0c647 in client_user_main (bc=0x5fed47a3d020) at ../../../src_copy/osmo-remsim/src/client/user_shell.c:185 #26 0x00005fed1ca0cc47 in main (argc=1, argv=0x7ffd6c845c48) at ../../../src_copy/osmo-remsim/src/client/remsim_client_main.c:221 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0da0b4354532b4e13d0c4bf4b132ec774f24497f Gerrit-Change-Number: 39920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 04 Apr 2025 11:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No