Attention is currently required from: daniel, fixeria, lynxis lazus, osmith. Hello Jenkins Builder, daniel, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Use gsup_client_mux from libosmo-gsup-client ...................................................................... Use gsup_client_mux from libosmo-gsup-client gsup_client_mux code was cloned a couple months ago to libosmo-gsup-client, use it in osmo-msc and drop its own copy. The code was not dropped at the time because it required tweaking the unit tests, because they were wrapping some underlaying functions which cannot be wrapped anymore since the code using them is now inside the separate already-linked libosmo-gsup-client.so. Solve it by actually wrapping one layer up in the gsup_client_mux itself since it now something we mantain here anymore. Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 --- M TODO-RELEASE M include/osmocom/msc/Makefile.am D include/osmocom/msc/gsup_client_mux.h M src/libmsc/Makefile.am M src/libmsc/e_link.c M src/libmsc/gsm_04_11_gsup.c M src/libmsc/gsm_09_11.c D src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/osmo-msc/msc_main.c M tests/msc_vlr/Makefile.am M tests/msc_vlr/msc_vlr_tests.c 13 files changed, 49 insertions(+), 250 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/39019/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 Gerrit-Change-Number: 39019 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>