Attention is currently required from: fixeria, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email )
Change subject: Add logging category for libosmo-cc
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/core/logging.h:
https://gerrit.osmocom.org/c/libosmocore/+/35572/comment/53eb6a19_6c10ed3c
PS2, Line 158: #defin
IIRC there's a static array of size OSMO_NUM_DLIB […]
I see. However, still the API is being changed due to modification of OSMO_NUM_DLIB.
TBH, though there are exceptions, it makes much more sense that each library dynamically defines its own set of log categories which can be configured through API, like we did in libosmo-gprs-*. It looks totally weird that adding a new log category in some random library requires a bump in libosmocore...
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35572?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9df433b2cfb51f04dbf16e9f8dee567a59ab5cb7
Gerrit-Change-Number: 35572
Gerrit-PatchSet: 3
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 24 Jan 2024 17:43:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment