Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 ) Change subject: sndcp: Put decompress handling code into helper function ...................................................................... Patch Set 1: (3 comments) File src/sgsn/gprs_sndcp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/43443734_fe8f300c PS1, Line 294: static uint8_t *decompress_segment(struct gprs_sndcp_entity *sne, void *ctx, const uint8_t* compressed_data, unsigned int compressed_data_len, unsigned int *decompressed_data_len) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/a17cc67c_1ba328d1 PS1, Line 301: DEBUGP(DSNDCP, " \n"); unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/7da1ce46_4762de40 PS1, Line 335: DEBUGP(DSNDCP, " \n"); unnecessary whitespace before a quoted newline -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 06 Dec 2022 10:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment