Attention is currently required from: roox, laforge, roh.
tnt has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017 )
Change subject: icE1usb: Move GPS-DO USB control to separate USB interface
......................................................................
Patch Set 2:
(1 comment)
File firmware/ice40-riscv/icE1usb/usb_str_app.txt:
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017/comment/3c550f1a_6298…
PS2, Line 12: GPS-DO control
Actually while you're at it shifting things, could you put that string before DFU
string and adapt the index in the descriptors ? Just to keep things in the same order.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27017
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Icd6555a14896c38626fb147b78af44ff719f2254
Gerrit-Change-Number: 27017
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: roh <jsteiger(a)sysmocom.de>
Gerrit-Reviewer: roox <mardnh(a)gmx.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: roox <mardnh(a)gmx.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: roh <jsteiger(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 01 Feb 2022 16:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment