Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 )
Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ......................................................................
Patch Set 2:
(4 comments)
File src/host/layer23/include/osmocom/bb/common/sysinfo.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/97ceb232_4d6d5da3 PS2, Line 74: uint8_t supported; this is really a bool right?
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/b8ddc33c_09fcce72 PS2, Line 79: uint8_t hopping; bool
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/7e4363ff_7d890521 PS2, Line 107: uint8_t egprs_supported; bool
File src/host/layer23/src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/1827ca55_686d6db3 PS2, Line 893: s->gprs.ctrl_ack_type = !gco->CONTROL_ACK_TYPE; /* inversed */ why are you inverting this here?