Attention is currently required from: osmith, pespin.

pablo has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )

Change subject: gtp-link: add IPv6 support ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/026227a1_8f28a014 PS1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN

It would be great that while doing this we take into account that we will want to specify an outer I […]

Yes, it is possible to extend this to specify the listener address.

How should I process? Does this require a new patch version? If so, how can I submit it to this Gerrit change?

https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/91d144f7_00135eaa PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN

Also, afaiu it should be possible to have one tunnel bind to both an IPv4 and an IPv6 address, and d […]

Dual stack is support for both inner MS IP address and outer GTP IP address.

1) Dual stack example for inner address:

gtp-tunnel add gtp0 v0 1 10.141.10.2 b010::11 gtp-tunnel add gtp0 v0 1 a010:: b010::11

2) Dual stack example for outer GTP address (this requires two GTP devices, one gtp0 for IPv4 and one gtp1 for IPv6)

gtp-tunnel add gtp0 v1 1 1 10.141.10.2 192.168.10.11 gtp-tunnel add gtp1 v1 1 1 10.141.10.2 a010:: b010::10

... and it is possible to combine both, dual stack in inner MS IP address and outer GTP IP address.

File tools/gtp-link.c:

https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/3d011949_89537c74 PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2);

I'd welcome if we could rename this fd1 and fd2 to fd0 and fd1u to name which proto are they used fo […]

I'm fine with that readibility cleanup