[XS] Change in osmo-ggsn[master]: gtp: allow packets with E-bit set - gerrit-log

12 Oct 2024


      Attention is currently required from: osmith, pespin.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email )
Change subject: gtp: allow packets with E-bit set
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38383/comment/2f0f6eac_dc4b96fe?usp... :
PS1, Line 17: Related: OS#6223
...
What I'm missing here is: why is the ggsn expected to accept the packet instead of reject it? becaus […]
I think this needs some spec analysis of what the expected behaviour is when packets with unknown/unsupported extension headers are received.  I can see arguments either way, but would hope there's spec guidance for it.  If we cannot find anything, I'd agree with pespin.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38383?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ic62f95874a877a2f295765b807d7f23b011aeaa3
Gerrit-Change-Number: 38383
Gerrit-PatchSet: 1
Gerrit-Owner: osmith osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Sat, 12 Oct 2024 17:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de