Attention is currently required from: fixeria, jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34479?usp=email )
Change subject: ASCI: Add a flag to turn transmitter off or on ......................................................................
Patch Set 5:
(2 comments)
File include/l1ctl_proto.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/4e84bd6c_f5eaf139 PS5, Line 217: uint8_t tch_flags; this means we probably need to update the L1CTL implementations everywhere, eg TTCN3. Do we have some versioning of the proto? maybe move it to the end?
File src/host/layer23/src/mobile/gsm48_rr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34479/comment/9b358913_e98ba6f4 PS5, Line 3042: LOGP(DRR, LOGL_INFO, " Channel type %d, subch %d, ts %d, mode %d, audio-mode %d, flags %d, cipher %d\n", you most probably want to print flags with 0x02%x here
-
pespin