Attention is currently required from: Hoernchen, jolly, laforge.

lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email )

Change subject: ccid_device: Reject XfrBlock with zero-length data ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: Without your patch, it fails in ../ccid_common/iso7816_fsm.c:1260, the trace shows a different location, but line no 1260 is taking from parsing fmt & args from frame 2.

OSMO_ASSERT(msgb_length(tfp->tpdu) >= sizeof(*tpduh));

(gdb) bt #0 0x0000ae70 in bdg_bkptpanic (fmt=0x16635 "Assert failed %s %s:%d\n", args=...) at ../main.c:44 #1 0x000107ba in osmo_panic (fmt=0x16635 "Assert failed %s %s:%d\n") at panic.c:78 #2 0x00005cf0 in tpdu_s_init_action (fi=0x2000f070, event=<optimized out>, data=0x20013f60) at ../ccid_common/iso7816_fsm.c:1279 #3 0x0000ebda in _osmo_fsm_inst_dispatch (fi=0x2000f070, event=7, data=0x20013f60, file=0x1664d "../ccid_common/iso7816_fsm.c", line=402) at fsm.c:875 #4 0x00004f0a in iso7816_3_wait_tpdu_action (fi=0x2000ecd8, event=7, data=0x20013f60) at ../ccid_common/iso7816_fsm.c:407 #5 0x0000ebda in _osmo_fsm_inst_dispatch (fi=0x2000ecd8, event=event@entry=7, data=data@entry=0x20013f60, file=file@entry=0x16b4b "../ccid_common/ccid_slot_fsm.c", line=line@entry=366) at fsm.c:875 #6 0x000070f6 in iso_fsm_slot_xfr_block_async (cs=0x20001d48 <g_ci>, msg=0x20013f60, xfb=<optimized out>) at ../ccid_common/ccid_slot_fsm.c:366 #7 0x00004850 in ccid_handle_xfr_block (cs=0x20001d48 <g_ci>, msg=0x20013f60) at ../ccid_common/ccid_device.c:464 #8 ccid_handle_out (ci=ci@entry=0x20001d48 <g_ci>, msg=0x20013f60) at ../ccid_common/ccid_device.c:761 #9 0x0000bbac in feed_ccid () at ../main.c:509 #10 main () at ../main.c:731