Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email ) Change subject: ara_m: add export support for the ARA-M application ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File pySim/ara_m.py: https://gerrit.osmocom.org/c/pysim/+/37643/comment/9ebd59b3_ddd6a0de PS1, Line 430: if res_do: Too much nesting here, this is making the code harder to read/edit. You can reduce it by inversing this condition and returning early. You can also add a function for the inner loop body. https://gerrit.osmocom.org/c/pysim/+/37643/comment/68c234fd_1c70ed59 PS1, Line 432: if 'response_all_ref_ar_do' in res_do_dict and res_do_dict['response_all_ref_ar_do']: ``` if not res_do_dict.get('response_all_ref_ar_do', False): continue ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43 Gerrit-Change-Number: 37643 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 08:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment