Attention is currently required from: dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email )
Change subject: ara_m: add export support for the ARA-M application ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File pySim/ara_m.py:
https://gerrit.osmocom.org/c/pysim/+/37643/comment/9ebd59b3_ddd6a0de PS1, Line 430: if res_do: Too much nesting here, this is making the code harder to read/edit. You can reduce it by inversing this condition and returning early. You can also add a function for the inner loop body.
https://gerrit.osmocom.org/c/pysim/+/37643/comment/68c234fd_1c70ed59 PS1, Line 432: if 'response_all_ref_ar_do' in res_do_dict and res_do_dict['response_all_ref_ar_do']: ``` if not res_do_dict.get('response_all_ref_ar_do', False): continue ```