Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31096
)
Change subject: Mark *_fsm_timeouts as static
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/tbf_dl_ass_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/31096/comment/866b54ec_cac4cb9d
PS2, Line 40: const struct value_string tbf_dl_ass_fsm_event_names[] = {
(this could also go static)
https://gerrit.osmocom.org/c/osmo-pcu/+/31096/comment/20f53543_655acaba
PS2, Line 57: struct msgb *create_packet_dl_assign(const struct tbf_dl_ass_fsm_ctx *ctx,
(this too apparently. probably there's a couple more but i'm not bothering now)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31096
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibf2a6ee5636ae7102ffd13b7497769652bcc3202
Gerrit-Change-Number: 31096
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Jan 2023 19:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment