Attention is currently required from: laforge, pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/29264 )
Change subject: trxcon: Initial support for forwarding AMR
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2:
Looks good to me, LGTM!
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/2d6e425d_16a39102
PS1, Line 348: ffs
Didn't know about this function, nice.
File src/target/firmware/layer1/l23_api.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/29264/comment/f25434e8_00a7e33a
PS1, Line 729:
unrelated ws removal
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/29264
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia20bc96e39726a919a556c83c8be48cb31af7331
Gerrit-Change-Number: 29264
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Sep 2022 15:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment