neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27375 )

Change subject: silence bogus error: event not permitted: READY_TO_SWITCH_RTP ......................................................................

silence bogus error: event not permitted: READY_TO_SWITCH_RTP

During inter-BSC incoming handover, there is no previous lchan to be switched, so this event always comes in the READY state of lchan_rtp_fsm. No need to complain about that and confuse log readers.

Related: SYS#5864 Change-Id: I96fd53b8c8da621a40bd65f85070eabd030cc875 --- M src/osmo-bsc/lchan_rtp_fsm.c 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/27375/1

diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 62cd100..e117c65 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -522,6 +522,12 @@ lchan_rtp_fsm_state_chg(LCHAN_RTP_ST_ROLLBACK); return;

+ case LCHAN_RTP_EV_READY_TO_SWITCH_RTP: + /* Ignore / silence an "event not permitted" error. In case of an inter-BSC incoming handover, there is + * no previous lchan to be switched over, and we are already in this state when the usual handover code + * path emits this event. */ + return; + default: OSMO_ASSERT(false); } @@ -704,6 +710,7 @@ | S(LCHAN_RTP_EV_ESTABLISHED) | S(LCHAN_RTP_EV_RELEASE) | S(LCHAN_RTP_EV_ROLLBACK) + | S(LCHAN_RTP_EV_READY_TO_SWITCH_RTP) , .out_state_mask = 0 | S(LCHAN_RTP_ST_ESTABLISHED)