Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )
Change subject: rspro_server: fix releasing timed out clients ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/37bbf8b4_f8a3fae8?u... : PS1, Line 926: osmo_stream_srv_destroy(peer); osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do conn->peer here in order to avoid double free.
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/71677556_b7179cb8?u... : PS1, Line 938: if (conn->fi) { osmo_fsm_inst_free(conn->fi); conn->fi = NULL; }