[M] Change in pysim[master]: [4/6] personalization: refactor Pin, Adm - gerrit-log

13 Mar 2025


      Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email )
Change subject: [4/6] personalization: refactor Pin, Adm
......................................................................
Patch Set 3:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/39744/comment/ff328eb7_29d500b2?usp=ema... :
PS3, Line 408:     return (pe for pe in l if pe.type == wanted_type)
...
this seems a bit like a reimplementation of the ProfileElementList. […]
ProfileElementSequence.pe_by_type, yes! and also ProfileElementSequence.get_pes_for_type(), as i see now. Thanks, missed those for some reason back when i started.
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/39744?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I54aef10b6d4309398d4b779a3740a7d706d68603
Gerrit-Change-Number: 39744
Gerrit-PatchSet: 3
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Thu, 13 Mar 2025 20:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org