Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27528 )

Change subject: System Information Type 3: allow updating T3212 at run-time ......................................................................

Patch Set 2:

(1 comment)

File src/osmo-bsc/system_information.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/27528/comment/090fd1c2_0068740f PS2, Line 968: bts->si_common.chan_desc.t3212 = osmo_tdef_get(bts->network->T_defs, 3212, OSMO_TDEF_CUSTOM, 0);

I think this should be moved to gsm_bts_trx_set_system_infos()

I see no practical benefits of doing so. As I already explained, T3212 is specific to SI3 (despite being stored in 'bts->si_common'), so to me it's better to have the sync logic in here. Feel free to submit patches renaming s/si_common/si_params/ to avoid confusion.