Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 )
Change subject: fix coding of Network Instance IE ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/a6083bac_3c46af10 PS1, Line 13: These qualify for moving to libosmocore utils
BTW, libosmocore already offers some APN conversion API: https://cgit.osmocom. […]
SO IIUC the code that neels proposes here is not needed since the same is already implemented in libosmocore?
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/e1f9af35_922dc52e PS1, Line 86: static int strncpy_buf(char *buf, size_t buflen, const char *src, size_t len) len is "srclen"?