Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 )

Change subject: asn1tostruct: fix defines getting redefined ......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS3:

So you seem to fix some code generation in this patch, but I don't see any .c/.h files changes. […]

Yes. Here is the diff of the generated files with this patch: https://gitea.osmocom.org/osmith/osmo-iuh-generated-files/commit/80129270353...

File asn1/utils/asn1tostruct.py:

https://gerrit.osmocom.org/c/osmo-iuh/+/30088/comment/37a3bf1a_6ba209a1 PS3, Line 84: use the same type multiple times, in that case we use the actual name

Did you think about simply adding a suffix to it? like a counter if count != 1?

If somebody needs to actually use them / or debug the generated code for whatever reason, I think it's more useful to have the name of the field instead of a number. Because then you would need to look up the number again to know which field it actually is.