Attention is currently required from: laforge, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email )
Change subject: pfcp up_function_features: allow shorter lengths ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/4785212e_1fc325f7 PS1, Line 435: * if the peer sends less octets, make do with what we get. */
Thanks I didn't know that one :)
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/7822fac7_51050479 PS1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits));
where's the second memcpy? you mean avoiding memset and memcpy'ing the same location? I'm always hop […]
Yeah I meant memset+memcpy.
-
pespin