Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28063 ) Change subject: input/ipaccess: Don't start zero-ms timer on every write ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/28063/comment/af0190b7_05c61659 PS1, Line 535: } with this ancient code I'm not entirely sure if there are any writers which are "scheduled" after this piece of code and which might not call osmo_fd_write_enable(). So best to take it step by step. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9c379364e7e6afce35fc6316392b5b33748980f7 Gerrit-Change-Number: 28063 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 May 2022 18:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment