Attention is currently required from: dexter, fixeria, jolly, neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )
Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io
......................................................................
Patch Set 5:
(3 comments)
File include/osmocom/mgcp/mgcp.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/b9ee7d52_bf65578c
PS5, Line 4: *
maybe time to bump the (C)
ok, will do - but onlyin the C files where I'm actually adding code. The change here in the mgcp.h file is too minor for claiming copyright.
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e8161eee_ee547078
PS5, Line 1044: c
typo
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e4e096a3_d2d8b7a9
PS5, Line 1598: NOTICE
ERROR?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a
Gerrit-Change-Number: 36363
Gerrit-PatchSet: 5
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 02 Apr 2024 17:40:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Gerrit-MessageType: comment
laforge