Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36928?usp=email ) Change subject: pySim-shell: Migrate PySimApp.iccid to RuntimeState.identity['ICCID'] ...................................................................... Patch Set 1: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/36928/comment/945dcb4b_bdf6f414 PS1, Line 763: self._cmd.rs.identity['ICCID']) For the sake of consistency with `ATR`, which is only present in the dict if available, maybe do not assign `None` above and just do `self._cmd.rs.identity.get('ICCID', '(unknown)')` here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibdcf9a7c4e7e445201640bce33b768bcc4460db1 Gerrit-Change-Number: 36928 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 May 2024 19:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment