pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41848?usp=email )

Change subject: vty: Fix extern var declared inside ifdef ......................................................................

vty: Fix extern var declared inside ifdef

"extern struct host host;" was declared inside "ifdef HAVE_SYSLOG_H", but it is actually needed unconditionally because it's also used in the gsmtap log target, which is always built.

Change-Id: I9d769ff007a4eaf613691a0491b0b4e07472df98 --- M src/vty/logging_vty.c 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/41848/1

diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 84e3331..128b23a 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -39,6 +39,9 @@ #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h>

+/* From VTY core code. Used by gsmtap and syslog targets. */ +extern struct host host; + #define LOG_STR "Configure logging sub-system\n" #define LEVEL_STR "Set the log level for a specified category\n"

@@ -656,9 +659,6 @@ [7] = LOG_LOCAL7 };

-/* From VTY core code */ -extern struct host host; - static int _cfg_log_syslog(struct vty *vty, int facility) { struct log_target *tgt;