Attention is currently required from: fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email )
Change subject: e1line_dump_vty(): dump keepalive state and params
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/e1_input_vty.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/99e4898b_b5ff17d7
PS1, Line 460: static void e1line_ka_dump_vty(struct vty *vty, const struct e1inp_line
*line)
The problem here (in generic code path) is that you
cannot make assumptions on what kind of transpor […]
Ack
https://gerrit.osmocom.org/c/libosmo-abis/+/36342/comment/dc7f7e7f_ed9edc62
PS1, Line 473: vty_out(vty, "(driver's default)");
See the comment above.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/36342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I17bd991850333ee794ab216f474b5e045fb01fa3
Gerrit-Change-Number: 36342
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 11:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment