Attention is currently required from: arehbein, fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 )
Change subject: PCU IF: Update NSE timer field
......................................................................
Patch Set 1:
(1 comment)
File include/osmo-bts/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/f75f14d8_55f0e308
PS1, Line 156: PCU_IF_NUM_NSE_TIMERS
You could move nse_timer[] to the end of the struct. […]
Extending the timer at the end of the struct would change the message size and hence would break the ABI.
I wouldn't really care for now about that, I don't expect the size of this array to change lots of times. I'd leave it as/where it is, update the size now like you did.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31885
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb
Gerrit-Change-Number: 31885
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 16 Mar 2023 10:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein
arehbein@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment
pespin