Change in osmo-pcu[master]: gprs_pcu: Explicitly free all bts objects in list before freeing pcu - gerrit-log

10 May 2022


      Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28075 )
Change subject: gprs_pcu: Explicitly free all bts objects in list before freeing pcu
......................................................................
Patch Set 1:
(1 comment)
File src/gprs_pcu.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/28075/comment/48124af3_c2172eeb 
PS1, Line 66: 		talloc_free(bts);
...
I don't see how this iterates over the whole list, doesn't one need to use llist_for_each_entry_safe […]
The BTS destructor calls llist_del().
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If2a8360e214d993a8a89993532ff1099b30bdbb1
Gerrit-Change-Number: 28075
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Tue, 10 May 2022 12:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment